Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for --force-renderer-accessibility Electron argument, needed for Linux accessibility #84833

Closed
ndarilek opened this issue Nov 14, 2019 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-electron Electron-VS Code issues
Milestone

Comments

@ndarilek
Copy link

Lots of work has gone into Chromium accessibility under Linux, and many Electron apps are becoming accessible under Orca. Unfortunately, as of now this requires passing a --force-renderer-accessibility command line parameter, which presumably Electron/Chromium handles under the hood. Many Electron apps handle this, but VSCode seems to intercept command line parsing and doesn't support this flag.

Is it possible to either support this flag directly in VSCode, or to offer a command line parameter for passing additional flags directly to Electron?

I'm not sure if using this flag will even make a difference now, since this work is still in its early stages. But without it, VSCode can't currently use any of the current Linux accessibility work, and likely won't become even slightly usable until the late stages when the command line flag becomes unnecessary.

Thanks.

@adil-s
Copy link

adil-s commented Nov 14, 2019

👍

@deepak1556
Copy link
Contributor

/cc @bpasero

@bpasero
Copy link
Member

bpasero commented Nov 15, 2019

/cc @aeschli for CLI support

@bpasero bpasero added feature-request Request for new features or functionality workbench-electron Electron-VS Code issues labels Nov 15, 2019
aeschli added a commit that referenced this issue Nov 15, 2019
@aeschli
Copy link
Contributor

aeschli commented Nov 15, 2019

added --force-renderer-accessibility to the list of accepted cli arguments.

@deepak1556 deepak1556 assigned aeschli and unassigned deepak1556 Nov 15, 2019
@aeschli aeschli added this to the November 2019 milestone Dec 5, 2019
@aeschli aeschli added the verification-needed Verification of issue is requested label Dec 5, 2019
@aeschli aeschli closed this as completed Dec 5, 2019
@jrieken jrieken added the verified Verification succeeded label Dec 5, 2019
@jrieken
Copy link
Member

jrieken commented Dec 5, 2019

@aeschli Does it make sense to support this flag in the runtime args file?

@aeschli
Copy link
Contributor

aeschli commented Dec 5, 2019

@1`

@aeschli Does it make sense to support this flag in the runtime args file?

I guess yes, @bpasero manages that.

@bpasero
Copy link
Member

bpasero commented Dec 5, 2019

Let's do it when we have an overwhelming set of people asking for it. Also note that not every command line flag can be defined programmatically. Some need to be on the CLI for Chrome to pick up early.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-electron Electron-VS Code issues
Projects
None yet
Development

No branches or pull requests

6 participants