Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox crashes when I click on a link in VSCode. #85344

Closed
rumble19 opened this issue Nov 21, 2019 · 7 comments · Fixed by #94503
Closed

Firefox crashes when I click on a link in VSCode. #85344

rumble19 opened this issue Nov 21, 2019 · 7 comments · Fixed by #94503
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member linux Issues with VS Code on Linux snap Issues related to the snap package verified Verification succeeded
Milestone

Comments

@rumble19
Copy link

Issue Type: Bug

  1. Brand new Ubuntu 19.10 install. Comes with firefox installed and set as default browser.
  2. Install VSCode from "ubuntu software".
  3. Click any link inside of VSCode, for example Help> Tips and Tricks.
  4. Firefox crashes.

VS Code version: Code 1.40.1 (8795a98, 2019-11-13T16:49:30.162Z)
OS version: Linux x64 5.3.0-23-generic snap

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 3456)
GPU Status 2d_canvas: unavailable_software
flash_3d: disabled_software
flash_stage3d: disabled_software
flash_stage3d_baseline: disabled_software
gpu_compositing: disabled_software
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: disabled_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: disabled_software
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
Load (avg) 0, 0, 1
Memory (System) 15.38GB (5.81GB free)
Process Argv --force-user-env --no-sandbox --unity-launch --no-sandbox
Screen Reader no
VM 0%
Extensions: none
@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member linux Issues with VS Code on Linux upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 23, 2019
@francogu
Copy link

@jsantias
Copy link

I followed ctaggart's workaround (#75579) and was able to resolve this issue.

  1. Remove and purge the current installation sudo apt remove code --purge
  2. Download and install the deb package from https://code.visualstudio.com/download
    sudo apt install ./<vscodefile>.deb

@arnas
Copy link

arnas commented Feb 8, 2020

Had same issue with code installed with a snap. Installed it as deb package fixed issue too.

@joaomoreno joaomoreno self-assigned this Feb 17, 2020
@joaomoreno joaomoreno added the snap Issues related to the snap package label Feb 17, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Feb 17, 2020
@joaomoreno
Copy link
Member

joaomoreno commented Feb 17, 2020

This is the same underlying cause as #90806.

@sergiusens has pointed out the root cause in https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1838129:

If I were a betting person, I would put my stakes on gdk-pixbuf (https://github.com/snapcrafters/vscode/blob/master/files/bin/wrapper#L36)

Crash is gone after unsetting the following env:

sergiusens@umbar:/snap/code/25$ unset GDK_PIXBUF_MODULE_FILE
sergiusens@umbar:/snap/code/25$ unset GDK_PIXBUF_MODULEDIR

@deepak1556 Know anything about gdk-pixbuf?

@sergiusens
Copy link
Contributor

@joaomoreno I have a LD_PRELOAD related solution I can share (which wouldn't touch code's code), but if on launch those can be unset if code or code-insiders is in process.env "SNAP_NAME", that should solve the problem too.

@ygbr
Copy link

ygbr commented Feb 28, 2020

On Ubuntu 19.10 uninstalling the "Firefox Web Browser" pre-installed deb package and installing the package named as just "Firefox" (packaged as a snap by Mozilla itself) on the Ubuntu Software store did the trick.

@Tyriar
Copy link
Member

Tyriar commented Apr 1, 2020

Advice from snapcraft team: this should be fixed by removing the following environment variables after start up:

GDK_PIXBUF_MODULE_FILE
GDK_PIXBUF_MODULEDIR

@joaomoreno joaomoreno modified the milestones: Backlog, April 2020 Apr 2, 2020
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Apr 2, 2020
joaomoreno added a commit that referenced this issue Apr 3, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member linux Issues with VS Code on Linux snap Issues related to the snap package verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants