JavaScript: Improve indentation on insert with trailing newline

[SillyFreak]

Let's say I have the following JS snippet:

() => {
  a
}

() => {
  b
}

Now select the entire 'a' part, from the start of line 1 to the start of line 4, i.e. including a trailing newline, and insert it at the start of the line now containing 'b'. The result is this:

() => {
  a
}

() => {
  () => {
    a
  }
    b
}

The 'b' is now over-indented because that line received additional indentation at insert. Expected behavior: the 'b' should remain at its original indentation level. I can confirm this behavior at least for JS and JSON files.

---

The reason I care is that selecting whole lines with the keyboard is the easiest from start to start, so this kind of pasting is very common in my workflow. I often do Ctrl+C, Ctrl+V, Ctrl+V to duplicate lines; with this bug, this will add two additional indentations to the next line, which is potentially unrelated to the copied lines.

[jzyrobert]

Would something like this be acceptable?

On the last paste line, if

• range.endColumn is 1 (Just a newline pasted)
• lineLength of that line is > 0 (So content existed before paste)

Then don't add extra indent?

[SillyFreak]

I think that's consistent with my mental model, that pasting should behave like the following:

1. do the paste without any auto-indentation
2. select exactly the text that was pasted
3. use tab to indent to the level of the insertion position

So in the case that the insertion range ended at the start of the line (your first condition), the selection from 2. would have an empty last line which would not be indented during 3. I don't care about the second condition too much, as it's trailing whitespace that can be auto-removed. So yes, that sounds good!