Duplicate "Clear Search" and "No Settings Found" in settings-editor

[smilegodly]

I noticed in the settings-editor that there are now duplicate clear buttons when the user searches but finds no result.

I propose getting rid of the "Clear Search" text in the bottom left corner as there is now a button in the search bar that achieves the same thing but with less clutter (in my opinion). This change would make the settings-editor more consistent with the keyboard shortcuts tab as well.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Add a clear button to settings editor search bar (#82904)

[roblourens]

Yeah we can probably just get rid of the text link

[jzyrobert]

What about the "Clear Filters" link?
Should there be an extra Clear Filters button that appears in the search bar itself, or let the link stay?

[smilegodly]

@jzyrobert Would you mind sending me a picture of the "Clear Filters" link ? Where exactly is the link ?
I will look into this.

[jzyrobert]

@smilegodly

When you use one of the @ filters it appears.

[smilegodly]

For now I think we can let the 'Clear Filters' link stay. This issue was originally meant to get rid of the duplicates.
In another PR I could add a button to the search bar that adds this , and then we could get rid of that link though, although other tabs don't have that sort of button .
What do you think ? @roblourens

[roblourens]

Yeah the "Clear Filters" link is all about discoverability and I'd rather leave it