Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension profiler broken #86601

Closed
jrieken opened this issue Dec 9, 2019 · 3 comments
Closed

Extension profiler broken #86601

jrieken opened this issue Dec 9, 2019 · 3 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extension-host Extension host issues regression Something that used to work is now broken verified Verification succeeded
Milestone
November 2019

Comments

@jrieken
Copy link
Member

jrieken commented Dec 9, 2019 •
edited

The extension host profiling stopped working, not sure when that happens but it seems that scripts are now represented as url, e.g starting with file:// instead of c:/ or /foo. That breaks the look-up of profiler nodes in the extension directory.
@jrieken jrieken self-assigned this Dec 9, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug extension-host Extension host issues regression Something that used to work is now broken candidate Issue identified as probable candidate for fixing in the next release labels Dec 9, 2019
@jrieken jrieken added this to the November 2019 milestone Dec 9, 2019
@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2019

Actually already broken in 1.40...

@jrieken jrieken modified the milestones: November 2019, December 2019 Dec 9, 2019
@jrieken jrieken added candidate Issue identified as probable candidate for fixing in the next release and removed candidate Issue identified as probable candidate for fixing in the next release electron-6.0.x-update labels Dec 9, 2019
@jrieken jrieken modified the milestones: December 2019, November 2019 Dec 9, 2019
@jrieken
Copy link
Member Author

jrieken commented Dec 9, 2019

Still bringing this up for 1.41 - despite it being broken since a longer while

jrieken added a commit that referenced this issue Dec 9, 2019
@jrieken
ensure callFrame#url is successful, #86601
eab8ca7
jrieken added a commit that referenced this issue Dec 9, 2019
@jrieken
ensure callFrame#url is successful, #86601
3b948e4
@jrieken jrieken mentioned this issue Dec 9, 2019
Merged
@jrieken jrieken closed this as completed Dec 10, 2019
@jrieken jrieken added the verified Verification succeeded label Dec 10, 2019
@jrieken
Copy link
Member Author

jrieken commented Dec 10, 2019

Adding verified because of #86609 (comment)

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release extension-host Extension host issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
1 participant
@jrieken