New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning: matches multiple schemas when only one must validate #86738
Comments
This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines. Happy Coding! |
@Zx-EvM I'm unable to find the string "Matches multiple schemas when only one must validate." in the VSCode code base, so I believe this diagnostic is coming from an extension. |
@RMacfarlane issue reproduced with all extensions disabled |
@RMacfarlane I can repro this issue with latest insider and all extensions disabled. VS Code version: Code - Insiders 1.42.0-insider (cbeff45, 2019-12-13T07:08:57.560Z) System Info
Extensions (24)
Most likely this issue came from JSON Schema validator (might be earlier bundled with monaco monaco). However other cases in the internet were caused by problems with schema and fixes there. Will try to check if Windows Terminal has problems with linked schema |
@RMacfarlane reopen issue maybe? |
@Zx-EvM no reason to open this issue because problem is with schema Linked schema is UPD. Submitted PR to fix the schema microsoft/terminal#4045 |
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds proper `type` for `ProfilesObject` definition to avoid warnings about matches of multiple schemas. <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References Original issue: #3909 Related PR: #3892 Relates VSCode issue: microsoft/vscode#86738 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [X] Closes #3909 * [X] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] No new tests ~Tests added/passed~ * [ ] No docs update needed ~Requires documentation to be updated~ * [X] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #3909 (marked as help wanted) <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Download `doc/cascadia/profiles.schema.json` locally 1. Open `profiles.json` from WT in VSCode 1. Replace `$schema` value with path to local copy (verified that all errors are still in place and validations works as before) 1. Update it with `type` on `ProfilesObject` 1. Check that `Matches multiple schemas when only one must validate` warning is fixed
I use VSCode to edit
profiles.json
settings file for Windows Terminal.My config looks this:
I noticed that VSCode shows warning in status bar:
Screenshot:
Is there something wrong with my
profiles.json
? Or it's just bug?Related issue in WT repo: microsoft/terminal#3909
The text was updated successfully, but these errors were encountered: