Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roblox XML file syntax highlight support #87755

Merged
merged 3 commits into from Jan 7, 2020
Merged

Roblox XML file syntax highlight support #87755

merged 3 commits into from Jan 7, 2020

Conversation

Nightheart0
Copy link
Contributor

@Nightheart0 Nightheart0 commented Dec 27, 2019

I work with Rojo every day. However it is really annoying when VS Code doesn't syntax highlight Roblox place or model files and I have to manually select XML as the language. Roblox files are in XML format so I just added those extensions to XML syntax highlighting extension json

EDIT: This is my first PR ever so if I am doing something wrong, not following contributing guide 100%, something is missing or something like that, please let me know and I will fix that

@alexr00 alexr00 added this to the January 2020 milestone Jan 6, 2020
@alexr00
Copy link
Member

alexr00 commented Jan 6, 2020

Roblox seems pretty specific. @aeschli how specific is too specific for adding file extensions?

@cat-kitten one solution for you would be to add a file association in your settings:

	"files.associations": {
		"*.rbxlx": "xml"
	}

@aeschli
Copy link
Contributor

aeschli commented Jan 7, 2020

@alexr00 As the extension is so specific I think we can add it to our defaults, for a good initial user experience.

@alexr00 alexr00 merged commit db0c41c into microsoft:master Jan 7, 2020
@tisaconundrum2
Copy link

I'm over here reviewing the change log and I see robolox. I couldn't help but come over here to find out the reason behind this. Congrats @cat-kitten on your first merged PR.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants