Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour the optional endLine and endColumn attributes of StackFrame and Breakpoint #8851

Closed
weinand opened this issue Jul 7, 2016 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jul 7, 2016

If a StackFrame or a Breakpoint has an optional end location, show the character range instead of the full line.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 7, 2016
@isidorn isidorn added this to the August 2016 milestone Jul 22, 2016
@isidorn isidorn modified the milestones: September 2016, August 2016 Aug 24, 2016
@isidorn isidorn modified the milestones: Backlog, September 2016 Sep 5, 2016
@weinand weinand modified the milestones: April 2017, Backlog Apr 5, 2017
@kieferrm kieferrm mentioned this issue Apr 6, 2017
15 tasks
@isidorn
Copy link
Contributor

isidorn commented Apr 26, 2017

Was last week on vacation, it is better to move this to may than to work on it in endgame week.

@isidorn isidorn modified the milestones: May 2017, April 2017 Apr 26, 2017
@kieferrm kieferrm mentioned this issue May 5, 2017
44 tasks
isidorn added a commit that referenced this issue May 10, 2017
isidorn added a commit that referenced this issue May 10, 2017
@isidorn
Copy link
Contributor

isidorn commented May 11, 2017

Now we are respecting the endColumn and endLine number on the VSCode side.
If an adapter provides an endLine and endColumn for a stack trace we will decorate it with a stronger color such that it is clear for the user the exact range a stack frame has. Note that I have hacked the node debugger to return endColumn and endLine to produce this gif.

If a breakpoint has an endColumn and endLine upon clicking on it in the breakpoint view we will now select the whole breakpoint range.

@gregg-miskelly let us know if this works for you since as far as I understand the C# adapter provides endLine and endCOlumn.

stackframeranges

bpsselection

@gregg-miskelly
Copy link
Member

@isidorn Thanks! It looks great. I am assuming this should go out in the stable channel in early June. Is that correct?

cs-column-range

@isidorn
Copy link
Contributor

isidorn commented May 15, 2017

@gregg-miskelly yes that is correct. Feel free to provide additional issues with feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants