Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimap shows only half of select all selection #89354

Closed
Tyriar opened this issue Jan 27, 2020 · 4 comments
Closed

Minimap shows only half of select all selection #89354

Tyriar opened this issue Jan 27, 2020 · 4 comments
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 27, 2020

After cmd+a on latest insiders (mac)

Screen Shot 2020-01-27 at 8 39 23 AM
@connor4312
Copy link
Member

Are you on a high DPI monitor?

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues labels Jan 27, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Jan 27, 2020

@connor4312 yep, macbook monitor.

@connor4312
Copy link
Member

Cool, thanks. I know where the bug is.

@connor4312
Copy link
Member

To verify:

  1. With the minimap enabled on a high DPI (e.g. macbook) display, open a large file that takes the whole minimap height.
  2. Select all
  3. Verify all lines in the minimap are shown as selected

connor4312 added a commit that referenced this issue Jan 27, 2020
@connor4312
minimap: fix decoration cutoff not acocunting for pixel ratio
35116fa 
Fixes #89354
@connor4312 connor4312 added the verification-needed Verification of issue is requested label Jan 27, 2020
@RMacfarlane RMacfarlane mentioned this issue Feb 3, 2020
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 12, 2020
@rzhao271 rzhao271 added the author-verification-requested Issues potentially verifiable by issue author label Oct 27, 2020
@github-actions github-actions bot removed the author-verification-requested Issues potentially verifiable by issue author label Oct 27, 2020
@Tyriar Tyriar added the verified Verification succeeded label Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug editor-minimap Code/Text minimap widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Tyriar @connor4312 @RMacfarlane @rzhao271