Add Untitled-x to the title attribute of Untitled files

[IllusionMH]

With recent changes Untitled files display first line content as editor tab name and Untitled-x as description, however title attribute only contains first line content.

And while Untitled-x as description helps to avoid ambiguity between tabs with same first line content, it is impossible to rely on title in case when I have "workbench.editor.tabSizing": "shrink" or in Open Editors section.

It can be import React from 'react'; - Untitled-2 (using same separator as in window title) or something like Untitled-2: import React from 'react'; (may be Untitled-2 editor: import React from 'react'; )

Editor tabs for saved files have full path to file which helps to avoid ambiguity.

/cc @bpasero

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Add separate setting to force Untitled-x file names (#88971)

[bpasero]

@IllusionMH to be clear you are asking for having the "<first line> <untitled-n>" for the title attribute of labels so that this appears in the hover?

[IllusionMH]

Yes.

Some separator would be nice so Untitled-8 won't blend with content

[bpasero]

Yeah, maybe we could use a dot as separator, similar to how we do it for multi root labels.

[bpasero]

Verification: hover over an untitled editor tab and verify:

• you see the "Untitled-N" in the hover separated by a dot from the name of the untitled editor if the first line of the editor has words
• you do not see it twice if the first line does not contain words

[bpasero]

@IllusionMH can you verify from insiders? Then I can set the verified label.

[IllusionMH]

@bpasero sorry - missed this one.

Editor tabs and Open editors entries have expected title.
Search result has previously used title \Untitled-1 but it's not ambiguous.

However noticed that display of tile looks strange if there are no words in first line:

Old (1.41.1)

With words (Untitle-1 in description, looks good)

No words (\ in description - looks strange)

Is it intended? Can \ be removed?

[bpasero]

Thanks, I will check this out.

[bpasero]

Yeah good catch, I was not properly setting the title for the label for untitled. It should now be the same as for the editor:

[IllusionMH]

@bpasero
I checked all places (tabs, open editors, and search results entries) - everything looks as expected.
Also nice to see that there are no extra \ in search results.

Thanks!

Version: 1.43.0-insider (user setup)
Commit: 07c3397
Date: 2020-02-24T05:33:18.353Z

[bpasero]

Thanks, adding verified label thereby.