Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better link foreground color for focused problem #89933

Closed
octref opened this issue Feb 3, 2020 · 3 comments
Closed

Better link foreground color for focused problem #89933

octref opened this issue Feb 3, 2020 · 3 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release error-list Problems view verified Verification succeeded
Milestone
February 2020

Comments

@octref
Copy link
Contributor

octref commented Feb 3, 2020 •
edited

Ref: #11847

Link's foreground color does not good contrast against focused background:

image

image

image
@octref octref added bug Issue identified by VS Code Team member as probable bug error-list Problems view labels Feb 3, 2020
@octref octref added this to the February 2020 milestone Feb 3, 2020
@octref octref self-assigned this Feb 3, 2020
@octref
Copy link
Contributor Author

octref commented Feb 27, 2020

I tested dark/light/hc/nord.

image

image

image

image

@octref octref closed this as completed in 8c168ae Feb 27, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Feb 28, 2020
@RMacfarlane
Copy link
Contributor

The color contrast ratio when hovering on the link in Light+ is 1.3:1, I think we're aiming for 4.5:1. Dark actually also fails, it's 4.0:1 right now.

@RMacfarlane RMacfarlane reopened this Feb 28, 2020
@RMacfarlane RMacfarlane added verification-found Issue verification failed and removed verified Verification succeeded labels Feb 28, 2020
@octref
Copy link
Contributor Author

octref commented Feb 28, 2020 •
edited

I have decided to not have any hover effect on focused links for the upcoming release.

image

I think this is fine since the underline still indicates the link and people can hover over the link to see tooltip.

@joaomoreno textLink.foreground seems to have bad contrast to tree's list.activeSelectionBackground. Is there a place where we already render link in active selection in a tree? Or should I introduce a new color?

@octref octref added candidate Issue identified as probable candidate for fixing in the next release and removed verification-found Issue verification failed labels Feb 28, 2020
octref added a commit that referenced this issue Feb 28, 2020
@octref
Fix #89933
df50184
roblourens added a commit that referenced this issue Feb 28, 2020
@roblourens
Merge pull request #91783 from microsoft/pine/89933
6947926 
Fix #89933
@octref octref closed this as completed in b393709 Feb 28, 2020
@roblourens roblourens added the verified Verification succeeded label Mar 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release error-list Problems view verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@roblourens @RMacfarlane @octref