[php] Ability to turn off PHP autocompletion by VSCode

[Ciantic]

There is now a better Intellisense plugins for Vscode PHP: vscode-php-intellisense and crane.

In it's known issues it says "There may be duplicate suggestions for functions or variables. This is because VS Code has it's own (very limited) code-completion support for PHP, and there is currently no way to turn this off."

This indeed is annoying, the vscode suggestions are too broad and are just noise compared to accurate entries by crane.

[jrieken]

It should be possible to uninstall the VS Code php extension.

[jrieken]

@joaomoreno fyi

[Ciantic]

I think crane still uses vscode's syntax highlighter for PHP. So if one were to remove VSCode's internal PHP extension, would it also remove the syntax highlighter?

P.S. I think simple options would suffice, e.g. "php.vscode.autocomplete", so it could be turned off.

[jrieken]

Yes - but we can also think about splitting our extension into one part that does highlighting and bracket config and another that does completions. That would allow for more freedom.

[Ciantic]

This is now annoying the testing of proper language server in here : felixfbecker/php-language-server#165

Quote:

VS Code has its own inferior completion. The only way to disable is going to the installation dir under resources/app/extensions/php/out/phpMain.js and commenting out the registration of the completionProvider.

P.S. I think the option would be a simplest thing to implement for now.

[felixfbecker]

Related #16586

[felixfbecker]

Any update on this?

[felixfbecker]

I have been holding back the PHP IntelliSense release with intelligent completion for over a month now because it is useless if VS Code just spams the completion list with countless functions that do not make sense in the context. When will we get the option to disable or uninstall the built-in PHP completion?

[mousetraps]

I agree it makes sense to provide a temporary option to disable this. Just submitted a PR here: #19015

[mousetraps]

Also @felixfbecker, just checking - at this point in time, is there anything else about the built-in support that is interfering with the experience? (hover, signature help, etc.?)

[felixfbecker]

@mousetraps thanks for looking into this. Signature help is being implemented right now, iirc there is no built-in hover. It would be great if all of them could be disabled (everything except syntax highlighting).

[aeschli]

I pushed the PR and changes the setting name for the code completion to "php.suggest.basic".
If disabled, hover and signature help are also disabled.

[ADmad]

I don't think the php.suggest.basic setting achieves the desired result. Setting php.suggest.basic to false I no longer get completion suggestions even from PHP Intellisense extension. If have to use Ctrl + space to trigger the completion suggestions list.

[felixfbecker]

@ADmad I don't think this is related, this only removes the built-in completion provider.

[ADmad]

So something else which controls the display of suggestions list from extensions like php intellisense is broken?

[aeschli]

Part of the January build.
Add
"php.suggest.basic": false
to your settings to disable all completions from the built-in PHP extension.