Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests: terminal throws exceptions #90046

Closed
bpasero opened this issue Feb 5, 2020 · 1 comment · Fixed by #90581
Closed

Integration tests: terminal throws exceptions #90046

bpasero opened this issue Feb 5, 2020 · 1 comment · Fixed by #90581
Assignees
@bpasero @Tyriar
Labels
debt Code quality issues integration-test-failure
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 5, 2020

Seeing this when running integration tests with latest today:

Unknown terminal: 18: Error: Unknown terminal: 18
    at MainThreadTerminalService._getTerminalProcess (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/browser/mainThreadTerminalService.js:282:23)
    at MainThreadTerminalService.$sendProcessReady (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/browser/mainThreadTerminalService.js:229:18)
    at RPCProtocol._doInvokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:331:27)
    at RPCProtocol._invokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:316:45)
    at RPCProtocol._receiveRequest (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:243:32)
    at RPCProtocol._receiveOneMessage (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:171:26)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:61:52
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:459:38)
    at BufferedEmitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:361:35)
    at PersistentProtocol._receiveMessage (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:580:37)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:454:83
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:459:38)
    at ProtocolReader.acceptChunk (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:187:37)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:156:61
    at Socket.listener (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/node/ipc.net.js:16:40)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:166:17)

[46612:0205/072944.291888:INFO:CONSOLE(1)] "xterm.js: Terminal.open was called on an element that was not attached to the DOM", source: /Users/bpasero/Development/Microsoft/monaco/node_modules/xterm/lib/xterm.js (1)
Unknown terminal: 14: Error: Unknown terminal: 14
    at MainThreadTerminalService._getTerminalProcess (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/browser/mainThreadTerminalService.js:282:23)
    at MainThreadTerminalService.$sendProcessReady (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/browser/mainThreadTerminalService.js:229:18)
    at RPCProtocol._doInvokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:331:27)
    at RPCProtocol._invokeHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:316:45)
    at RPCProtocol._receiveRequest (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:243:32)
    at RPCProtocol._receiveOneMessage (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:171:26)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/services/extensions/common/rpcProtocol.js:61:52
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:459:38)
    at BufferedEmitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:361:35)
    at PersistentProtocol._receiveMessage (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:580:37)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:454:83
    at Emitter.fire (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/event.js:459:38)
    at ProtocolReader.acceptChunk (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:187:37)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/common/ipc.net.js:156:61
    at Socket.listener (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/parts/ipc/node/ipc.net.js:16:40)
    at Socket.emit (events.js:203:13)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:276:11)
    at Socket.Readable.push (_stream_readable.js:210:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:166:17)
@bpasero bpasero self-assigned this Feb 13, 2020
bpasero added a commit that referenced this issue Feb 13, 2020
@bpasero
Integration tests: terminal throws exceptions (fix #90046)
54d57f5
@bpasero bpasero added the debt Code quality issues label Feb 13, 2020
@bpasero bpasero added this to the February 2020 milestone Feb 13, 2020
@bpasero bpasero mentioned this issue Feb 13, 2020
Merged
@bpasero
Copy link
Member Author

bpasero commented Feb 13, 2020

Looking at test output for 1 week now, I cannot stand this exception as I always think something is broken. PR: #90581

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
debt Code quality issues integration-test-failure
Projects
None yet
Milestone
February 2020
Development

Successfully merging a pull request may close this issue.

Integration tests: terminal throws exceptions microsoft/vscode
2 participants
@bpasero @Tyriar