Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move terminal unit tests to browser and common #90245

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Move terminal unit tests to browser and common #90245

merged 2 commits into from
Feb 10, 2020

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 7, 2020

@jrieken can you verify the .eslintrc and renderer.html changes are all good?

@Tyriar Tyriar added this to the February 2020 milestone Feb 7, 2020
@Tyriar Tyriar requested a review from jrieken February 7, 2020 16:54
@Tyriar Tyriar self-assigned this Feb 7, 2020
jrieken
jrieken approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tyriar Tyriar merged commit 5cfae25 into master Feb 10, 2020
@Tyriar Tyriar deleted the tyriar/browser_tests branch February 10, 2020 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @jrieken