Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AppCenter for crash reports #90491

Closed
1 of 2 tasks
JacksonKearl opened this issue Feb 11, 2020 · 5 comments
Closed
1 of 2 tasks

Migrate to AppCenter for crash reports #90491

JacksonKearl opened this issue Feb 11, 2020 · 5 comments
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.

Comments

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Feb 11, 2020

HockeyApp: error Error: Unexpected response: {"errors":{"app":["App cutover to App Center"]}} (AppID: df720085b30c42c09326b68b40f13a35)

TODO:

  • Enable automatic symbol uploads from the build pipeline
  • Get windows crash report working
JacksonKearl pushed a commit that referenced this issue Feb 11, 2020
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Feb 12, 2020
@bpasero bpasero assigned deepak1556 and unassigned bpasero Feb 12, 2020
@bpasero bpasero added workbench-diagnostics General VS Code built-in diagnostic issues debt Code quality issues labels Feb 12, 2020
@bpasero
Copy link
Member

bpasero commented Feb 12, 2020

Assigning to @deepak1556 who is taking care of moving us to the new crash world. We need to make sure that the automated publishing of versions still work in the new world and that we do not have to manually create versions.

@bpasero bpasero changed the title Hockeyapp phase causes Publish stage failure Migrate automated version creation to new AppCenter for crash reports Feb 12, 2020
@lumaxis
Copy link
Contributor

lumaxis commented Feb 12, 2020

@bpasero It does!
Let me know if you need any help with this.

@deepak1556
Copy link
Contributor

The current VS Code stable 1.43 ships with crashes reporting to appcenter on macOS, linux and windows. There are some followup issues that needs work and help from appcenter

  1. Crash reports from windows don't show up on appcenter, although they are sent are from the client and there is a successful correlation id.

Mathias Wenz from the Appcenter team spent time investigating this on the server side and found that the parsing of minidump files failed, the reason being minidump_stackwalk tool from breakpad that is used to generate the json format of symbolized data fails to escape some windows path with special characters like lowercase drive letters ex: "path":"\\?\d:\github\vscode\node_modules\vscode-sqlite3\build\Release\sqlite.node" . An internal support ticket has been raised for this, will add the link here once I obtain it.

  1. There are bogus crash reports from our macOS app that has no versions and no meaningful symbolized data, not sure where these are coming from. I have raised a support request for debugging this further, awaiting appcenter response. Here is a video demo of the issue https://streamable.com/urs7y , also this only affects macOS, linux reports are fine.

  2. Unable to use search filter with User ID, we use guid format for the user id, we are able to confirm the reports are present manually, just the search filter doesn't work on them. Again raised a support request, awaiting response.

Any help on moving these forward is appreciated. Thanks!

@deepak1556 deepak1556 changed the title Migrate automated version creation to new AppCenter for crash reports Migrate to AppCenter for crash reports Mar 9, 2020
@deepak1556 deepak1556 added engineering VS Code - Build / issue tracking / etc. and removed workbench-diagnostics General VS Code built-in diagnostic issues labels Mar 9, 2020
@deepak1556
Copy link
Contributor

Update:

  1. Have obtained internal bug report id https://dev.azure.com/msmobilecenter/Mobile-Center/_workitems/edit/77695

  2. Awaiting response.

  3. Was requested further debugging info, provided them today. Awaiting issue confirmation.

@bpasero
Copy link
Member

bpasero commented Jul 3, 2020

Isn't this complete?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

5 participants