Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+w on preview tab will close two tabs #86790

Closed
czastack opened this issue Dec 12, 2019 · 9 comments
Closed

ctrl+w on preview tab will close two tabs #86790

czastack opened this issue Dec 12, 2019 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone

Comments

@czastack
Copy link

  • VSCode Version: 1.40.2
  • OS Version: Linux x64 4.15.0-72-generic (Ubuntu 16.04)

Steps to Reproduce:

  1. Open a nornal file tab
  2. Open a preview tab, such as markdown preview, Jupyter Notebook, image file
  3. Press ctrl+w on the preview tab, then the preview tab and anthoter nornal file tab will close togeter
  4. If no nornal file tab opened, the whole window will close.
  5. If click on the Close button instead of ctrl+w, that is ok

Does this issue occur when all extensions are disabled?: Yes

@RMacfarlane
Copy link
Contributor

@czastack I'm having trouble reproducing this issue. Just to confirm, this also happens when all extensions are disabled? Do you have any custom keybindings?

@brycefranzen
Copy link

I opened an issue with a similar problem and it was closed as a duplicate, but it added further insight as to how to reproduce this:

Open 3 files. Select the far-right file.
Press cmd+w to close the tab.
Press cmd+w to close the next tab.

Notice the last two open tabs are closes simultaneously. This should only close ONE tab at a time.

This was NOT a bug in the previous version.
This appears to have been introduced in the recent update

Editor Version Information:
version: 1.41.0
commit: 9579eda
Date: 2019-12-11T17:58:38.338Z

Note this happens on ANY tab, NOT only "preview" tabs

@czastack
Copy link
Author

@RMacfarlane Yes. When I disable all the extentions and move ~/.config/Code into other name, the isuue also happens. Are you trying to reproduce this issue on linux system?

@bpasero bpasero assigned mjbvz and unassigned bpasero Dec 14, 2019
@bpasero bpasero added the webview Webview issues label Dec 14, 2019
@gregzuro
Copy link

gregzuro commented Jan 4, 2020

I see this on mac as well. It's erratic, though. Sometimes one tab closes, sometimes two.

Version: 1.42.0-insider
Commit: 7c0095e

@otafasd
Copy link

otafasd commented Feb 3, 2020

VSCODE ver: 1.41.1 26076a4 x64
OS ver: Ubuntu 18.04.3 LTS (64bit)

+1
In my case, I've never seted any keyboard shortcut.
ctrl +w always close my preivew window and markdown source window
( If source has any monification, pop up save or not question box )
It's very annoying problem.

@kaytwo
Copy link

kaytwo commented Feb 17, 2020

I can repro this in 1.42.1 in a clean install on linux.

  1. Create a file, add some text, save it as .md
  2. ctrl+shift+v to preview: this opens a preview tab
  3. ctrl+w while the preview tab has focus
  4. BOTH the preview tab and the .md source tab are closed

It appears to consume the ctrl+w twice: if tabs are rearranged (i.e. open a second file, and rearrange the tabs such that the second file is in bewteen the .md and the preview), whichever tab would have gotten focus after the preview was closed gets closed as well; if the preview tab is the only one remaining, the second ghost ctrl+w closes the window.

@scriptcoded
Copy link

I'm experiencing this issue in the stable version, but not in insiders. Has it been fixed?

It's only happening for images, and not for plain-text files.

Stable version:
Version: 1.43.0
Commit: 78a4c91
Date: 2020-03-09T19:44:52.965Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.3.0-42-generic

Insiders version:
Version: 1.44.0-insider
Commit: 64b65cf
Date: 2020-03-20T08:27:32.236Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.3.0-42-generic

@wdscxsj
Copy link

wdscxsj commented Mar 24, 2020

FWIW, after the Ctrl+W shortcut for workbench.action.closeWindow is deleted, this nagging issue never appears on my machine.

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Apr 15, 2020
@mjbvz mjbvz added this to the April 2020 milestone Apr 17, 2020
@mjbvz mjbvz closed this as completed in dbc7b4d Apr 17, 2020
@dbaeumer dbaeumer added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests