Address feedback for reset editor.lineNumbers after disabling zen mode #90910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses feedback given in #90822
@isidorn Not sure if I'm not understanding something but
transitionDisposables
just have an add and clear methods, and we need a way to keep track if an editor have already been added to avoid adding it multiple times so I just movededitorWidgetSet
insidethis.state.zenMode
object and used theonDidDispose
event to remove the disposed editors from the set.Let me know if I'm missing something