Enable Drag and Drop for views #90917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isidorn
requested changes
Feb 19, 2020
| @@ -134,6 +142,18 @@ export class CompositeBar extends Widget implements ICompositeBar { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (this.compositeTransfer.hasData(DraggedViewIdentifier.prototype)) { | |||
There was a problem hiding this comment.
It feels like we are duplicating this code in the compositeBar and compositeBarActions. Is it possible to have this code unified in one location?
| @@ -128,6 +128,53 @@ export class ActivitybarPart extends Part implements IActivityBarService { | |||
| getContextMenuActionsForComposite: () => [], | |||
| getDefaultCompositeId: () => this.viewletService.getDefaultViewletId(), | |||
| hidePart: () => this.layoutService.setSideBarHidden(true), | |||
| dndHandler: { | |||
There was a problem hiding this comment.
It seems like we are duplicating this code in the activityBar and the panelPart.
Could we use some shared CompositeDragAndDrop to be shared between this two parts?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#89729
Allows dragging views between containers (both existing and panel area).
Insights from testing: