Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal weirdness on Windows remote #91119

Closed
roblourens opened this issue Feb 21, 2020 · 4 comments
Closed

Terminal weirdness on Windows remote #91119

roblourens opened this issue Feb 21, 2020 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Milestone
Backlog

Comments

@roblourens
Copy link
Member

  • SSH from Mac to Windows remote
  • I am just collapsing and expanding the panel with cmd+J

Feb-20-2020 17-07-34
@IllusionMH
Copy link
Contributor

IllusionMH commented Feb 21, 2020 •
edited

Looks like behavior also described in #91135 (comment)

@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2020

So remote terminals are still stuck on winpty due to #76548, so behavior is expected to be a little different. Additionally resizing terminals can often cause weird wrapping problems for Windows, but it looks like collapsing the panel is causing a resize to fire with small dimensions which isn't expected.

This might be different to #91135, that may be a race with the viewport not updating when resizes happen in quick succession?

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Feb 21, 2020
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2020

While this bug may only be visible on Windows, the resize it likely also happening on Linux and mac which is redundant.

@Tyriar Tyriar added this to the Backlog milestone Feb 21, 2020
@Tyriar Tyriar mentioned this issue Feb 21, 2020
Closed
@Tyriar
Copy link
Member

Tyriar commented Feb 26, 2020

/duplicate #91135

@Tyriar Tyriar closed this as completed Feb 26, 2020
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 26, 2020
Tyriar added a commit that referenced this issue Feb 26, 2020
@Tyriar
Fix backwards layout in terminal
622ddc0 
Fixes #91580
Fixes #91135
Fixes #91119
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@roblourens @IllusionMH @Tyriar