Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List items should have role 'listitem' #91159

Merged
merged 1 commit into from
Feb 26, 2020
Merged

List items should have role 'listitem' #91159

merged 1 commit into from
Feb 26, 2020

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Feb 21, 2020 •
edited

fixes #90876

Tested it out and works fine.
@joaomoreno Not sure if you like where I set the default 'treeitem' for trees.

@isidorn isidorn added this to the February 2020 milestone Feb 21, 2020
@isidorn isidorn self-assigned this Feb 21, 2020
joaomoreno
joaomoreno approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joaomoreno joaomoreno merged commit db5d637 into master Feb 26, 2020
@joaomoreno joaomoreno deleted the isidorn/listRole branch February 26, 2020 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@isidorn isidorn

Labels
None yet
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.

List items should have role 'listitem'
2 participants
@isidorn @joaomoreno