Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editor: rename webview to panel #91568

Closed
bpasero opened this issue Feb 26, 2020 · 2 comments
Closed

Custom editor: rename webview to panel #91568

bpasero opened this issue Feb 26, 2020 · 2 comments
Assignees
@mjbvz
Labels
api custom-editors Custom editor API (webview based editors) verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 26, 2020

Refs: #91325

resolveCustomTextEditor(document: TextDocument, webview: WebviewPanel) => resolveCustomTextEditor(document: TextDocument, panel: WebviewPanel)

Otherwise I end up typing webview.webview all the time.
@mjbvz mjbvz added this to the February 2020 milestone Feb 26, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 26, 2020

Good suggestion! I'm going to change them to webviewPanel since that's what we use for the existing APIs in vscode.d.ts:

vscode/src/vs/vscode.d.ts

Line 6494 in a980d87

readonly webviewPanel: WebviewPanel;

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Feb 26, 2020
mjbvz added a commit that referenced this issue Feb 26, 2020
@mjbvz
Use better parameter name for webview panels
851cd9b 
For #91568
@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2020

Fixed. Just a d.ts update

@mjbvz mjbvz closed this as completed Feb 27, 2020
@mjbvz mjbvz added api custom-editors Custom editor API (webview based editors) labels Feb 27, 2020
@octref octref added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api custom-editors Custom editor API (webview based editors) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
3 participants
@bpasero @octref @mjbvz