Quick pick shows wrong selected items

[sandy081]

Steps to Repro

• Set up settings sync - Follow instructions here
• Turn on Sync
• From the gear icon, select Sync is on entry
• Quick pick is shown. From the quick pick click on Sync: Configure entry
  🐛 Quick pick with wrong selected items is shown

Expected:

Note: Expected is shown when you use keyboard to select Sync: Configure entry. It happens only when you use mouse and click.

[chrmarti]

@sandy081 There is a change event on the checkbox from the mouse up on the Sync: Configure entry. I don't have a fix in QuickInput currently, can we change

vscode/src/vs/workbench/contrib/userDataSync/browser/userDataSync.ts

Line 996 in 8ef18ac

run(): any { return that.configureSyncOptions(); }

to:

run(): any { return new Promise(r => setTimeout(r)).then(() => that.configureSyncOptions()); }

That appears to let the mouse up pass without triggering the change event on the checkbox.

[sandy081]

@chrmarti Is this a temp workaround and do you have plans to fix it in quick pick later?

[chrmarti]

@sandy081 It’s certainly a workaround. I don’t have a proper fix yet.