Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editor: closing custom editor does not dispose text model #91670

Closed
bpasero opened this issue Feb 27, 2020 · 2 comments
Closed

Custom editor: closing custom editor does not dispose text model #91670

bpasero opened this issue Feb 27, 2020 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 27, 2020

Refs: #91325

  • open a custom editor associated with a text document
  • close that editor

=> 馃悰 I see no dispose call to the text file editor model
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2020
@mjbvz mjbvz added this to the March 2020 milestone Feb 27, 2020
@mjbvz mjbvz added the custom-editors Custom editor API (webview based editors) label Feb 27, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2020

This is definitely a bug, however I'm holding off on fixing this until March because the fix is risky and because we don't ship any built-in text based custom editors

@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2020

I'll also add a test for this to the custom editor example extensions

@mjbvz mjbvz closed this as completed in 44c76bd Mar 3, 2020
mjbvz added a commit to mjbvz/vscode-experimental-webview-editor-extension that referenced this issue Mar 3, 2020
@mjbvz
And test to make sure text documents are not leaked
943d85c 
For microsoft/vscode#91670
@roblourens roblourens added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@roblourens @bpasero @mjbvz