Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Quickly closing a git commit message in VS code skips autosave, causing a #91709

Closed
lukewlms opened this issue Feb 27, 2020 · 3 comments · Fixed by #91732
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone

Comments

@lukewlms
Copy link

There appears to be a regression of this fix: #72573

  • VSCode Version: 1.42.1
  • OS Version: MacOS 10.14.6

Steps to Reproduce are identical to before:

  1. Add VS Code as git commit editor (code --wait)
  2. Perform a git commit
  3. Edit the commit message in Code
  4. Quickly close the commit message in Code, before autosave occurs

Result: git reports an empty commit message, even though Autosave is enabled in VS Code. This makes VS Code not very useful as a git commit message editor as I'm not certain it will actually save what I'm writing.

Does this issue occur when all extensions are disabled?: Yes

Thanks!

@vscodebot
Copy link

vscodebot bot commented Feb 27, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@roblourens
Copy link
Member

I can't repro this. What are your autosave settings?

@lukewlms
Copy link
Author

lukewlms commented Feb 27, 2020

As follows - 1 second with delay. Often I am pasting in a task identifier and immediately closing, which is very quick. (It seems the delay here should be irrelevant since I'm closing the file - autosave should always happen then, no?)

image

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2020
@bpasero bpasero added this to the February 2020 milestone Feb 28, 2020
bpasero added a commit that referenced this issue Feb 28, 2020
@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Feb 28, 2020
bpasero added a commit that referenced this issue Feb 28, 2020
@JacksonKearl JacksonKearl added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants