Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching (quote, bracket, paren) doesn't get deleted when hitting Ctrl+Backspace #91855

Closed
jjspace opened this issue Mar 1, 2020 · 3 comments
Closed

Matching (quote, bracket, paren) doesn't get deleted when hitting Ctrl+Backspace #91855

jjspace opened this issue Mar 1, 2020 · 3 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-autoclosing Editor automatic closing of parens / brackets / etc. insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2020

Comments

@jjspace
Copy link

jjspace commented Mar 1, 2020

  • VSCode Version: 1.42.1
  • OS Version: Fedora 29

Steps to Reproduce:

  1. Start with an empty opening & closing pair of quotes, brackets or parentheses.
    • This applies to auto closed pairs and manual ones
  2. Hit Backspace on the opening of the pair and they both get deleted
  3. Start with the pair again and hit Ctrl+Backspace and the closing of the pair is NOT deleted
  4. The expected behavior is that both methods would delete the closing of the pair on an empty pair (), [], '', "", etc

I specifically ran into this issue in JS and JSX but I think it would apply to other languages.
@vscodebot
Copy link

vscodebot bot commented Mar 1, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

tonyzhc added a commit to tonyzhc/vscode that referenced this issue Apr 21, 2020
@tonyzhc
Fixed inconsistency between delete and deleteAllLeft
fc9fdbc 
Trying to fix this issue: microsoft#91855
@tonyzhc tonyzhc mentioned this issue Apr 21, 2020
Closed
@rebornix rebornix added the feature-request Request for new features or functionality label Jul 22, 2020
@jjspace
Copy link
Author

jjspace commented Aug 15, 2020

@rebornix @tonyzhc Sorry to mention you but is there any update on this? It's a small bug but I run into it a fair bit and I'm hoping it can get fixed before the bot closes it down.

@rebornix rebornix assigned alexdima and unassigned rebornix Aug 17, 2020
@alexdima alexdima added editor-autoclosing Editor automatic closing of parens / brackets / etc. bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Aug 30, 2020
@alexdima alexdima modified the milestones: Backlog Candidates, Backlog Aug 30, 2020
@alexdima alexdima mentioned this issue Aug 30, 2020
Closed
@alexdima alexdima modified the milestones: Backlog, September 2020 Sep 22, 2020
meganrogge pushed a commit to meganrogge/vscode that referenced this issue Sep 22, 2020
@alexdima @meganrogge
Fixes microsoft#91855
eec7577
@jrieken jrieken added the verified Verification succeeded label Oct 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-autoclosing Editor automatic closing of parens / brackets / etc. insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

Fixed inconsistency between delete and deleteAllLeft tonyzhc/vscode
5 participants
@rebornix @jrieken @alexdima @jjspace and others