Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose of Emitters in TerminalInstance #92649

Closed
Tyriar opened this issue Mar 13, 2020 · 0 comments · Fixed by #128130
Closed

Dispose of Emitters in TerminalInstance #92649

Tyriar opened this issue Mar 13, 2020 · 0 comments · Fixed by #128130
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Milestone
July 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 13, 2020

Currently they are not disposed which could be leaking memory. This change it not as trivial as just registering them as that causes task integration tests to fail since they apparently rely on these events after disposal?
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Mar 13, 2020
@Tyriar Tyriar added this to the April 2020 milestone Mar 13, 2020
@Tyriar Tyriar self-assigned this Mar 13, 2020
@Tyriar Tyriar modified the milestones: April 2020, May 2020 Apr 13, 2020
@Tyriar Tyriar modified the milestones: May 2020, Backlog May 11, 2020
Tyriar added a commit that referenced this issue Jul 7, 2021
@Tyriar
Dispose of emitters on terminal instance
fbc5682 
Fixes #92649
@Tyriar Tyriar mentioned this issue Jul 7, 2021
Merged
@Tyriar Tyriar modified the milestones: Backlog, July 2021 Jul 7, 2021
Tyriar added a commit that referenced this issue Jul 7, 2021
@Tyriar
Unset active terminal group when last is removed
7d00e4e 
Part of #92649
@Tyriar Tyriar mentioned this issue Jul 8, 2021
Closed
Tyriar added a commit that referenced this issue Jul 14, 2021
@Tyriar
Unset active terminal group when last is removed
35b634d 
Part of #92649
Fixes #128255
Fixes #128236
@Tyriar Tyriar mentioned this issue Jul 14, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues
Projects
None yet
Milestone
July 2021
Development

Successfully merging a pull request may close this issue.

Dispose of emitters on terminal instance microsoft/vscode
2 participants
@Tyriar and others