QuickPick: on close shuold return focus to previously focused element

[alanrenmsft]

• VSCode Version: 1.43.0
• OS Version: mac OS catalina

Steps to Reproduce:

1. open a quick pick dialog from a button in the view header using keyboard
2. close the dialog

Expected: the keyboard focus should return to the view header button

I have created a simple extension to reproduce the issue: https://github.com/alanrenmsft/vscode-extension

and here is the recording:

This PR: #92969 will work for the scenarios where the original button is still present in the UI, but not for my scenario the view header buttons are only visible when the header is expanded and focused.

[isidorn]

We had a somewhat similar discussion regarding focus and action bar and what should happen on escape here #91085

Though I do agree it would be best if quick pick would return focus to where it was before quick pick was opened.
Currently quick pick just passes focus to the editor. Which is a good assumption which works great most of the time.

Though since this is a feature request against quick pick forwarding to @bpasero and @chrmarti

[bpasero]

This would probably annoy a lot of users that are used to focus returning to the editor. I would do a change only after careful consideration.

The focus is returned here:

vscode/src/vs/platform/quickinput/browser/quickInput.ts

Line 71 in dd0f2fe

returnFocus: () => host.focus(),

[chrmarti]

Did some testing and found that this might actually work well. We need to test it during daily work to be sure. I'm not sure in which cases this might be unexpected, but it does fix some obvious cases - like when the terminal has focus, you open the command palette and then escape to find the focus switched to the editor.

[chrmarti]

Change pushed to master for testing.

[bpasero]

@chrmarti it could break any command that expects focus to be in the editor when quick pick closes (talking about the command palette). Just so that you know...

[isidorn]

Good for pushing to master, so we see try it out and breakages early. Thanks

[chrmarti]

No feedback so far. Closing as fixed. :)