Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Must return promises/thenables? #93852

Closed
jrieken opened this issue Mar 31, 2020 · 3 comments
Closed

Must return promises/thenables? #93852

jrieken opened this issue Mar 31, 2020 · 3 comments
Assignees
@mjbvz
Labels
api
Milestone
April 2020

Comments

@jrieken
Copy link
Member

jrieken commented Mar 31, 2020 •
edited

re #93767

I cannot implement openCustomDocument sync, why?
@mjbvz mjbvz added this to the March 2020 milestone Mar 31, 2020
@mjbvz mjbvz added the api label Mar 31, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Mar 31, 2020 •
edited

Good suggestion.

All custom editor provider should probably return Thenable<T> | T (but not ProviderResult<T> since that allows undefined + null)

@mjbvz
Copy link
Contributor

mjbvz commented Mar 31, 2020

@jrieken Do you think methods like .save should also return Thenable<void> | void?

mjbvz added a commit that referenced this issue Mar 31, 2020
@mjbvz
Allow custom editor provider methods to be sync
92a4758 
For #93852
For #77131
@jrieken
Copy link
Member Author

jrieken commented Apr 1, 2020

Unsure for editing and friends. I stumbled over open because initially my implementation did nothing there

@mjbvz mjbvz modified the milestones: March 2020, April 2020 Apr 2, 2020
@mjbvz mjbvz closed this as completed in ffb3cb7 Apr 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@jrieken @mjbvz