Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: icons need love #93888

Closed
isidorn opened this issue Mar 31, 2020 · 3 comments
Closed

Notebooks: icons need love #93888

isidorn opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
notebook polish Cleanup and polish issue ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2020

Refs: #93742

Currently we use the following icons for notebooks. I see the followgin issues

  1. Clicking on the Lock Cell Icon and holding the Icon gets cliped becasue there is not enough vertical space
  2. We use the Continue icon for "Execute Notebook Cell". Which is wrong, we need a different icon here. Idealy the same one which we use on the left hand side. Which would just be a green triangle, which means execute everywhere we use
  3. For Run all Cells we use a single green triangle which is wrong imho. We should use an icon which represents multiple, so for example mulitple green triangeles
  4. Lock icon is the same icon which we use for Output do not scroll. I think we need a different icon here as it has a different meaning
  5. We use an X to delete a cell. Why not a trash can just like the terminal uses it

Screenshot 2020-03-31 at 13 28 12

@miguelsolorio
Copy link
Contributor

I believe this is the plan for the icons in the editor toolbar:

image

And these are the ones for the cell toolbar:
image

In terms of the lock icon representing lock scroll, the actual icon itself means lock and is very generic so we actually don't use it well in output.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 31, 2020

@misolori ok, we are aligned on the multiple play, looks good.
We could potential change the icon we use in output. Use the output icon with a small lock decoration?

@rebornix rebornix added the ux User experience issues label Mar 31, 2020
@rebornix rebornix added this to the March 2020 milestone Mar 31, 2020
@rebornix rebornix added the polish Cleanup and polish issue label Mar 31, 2020
rebornix added a commit that referenced this issue Mar 31, 2020
@rebornix
Copy link
Member

I updated the icons accordingly. For the lock icon update in output, please file new issues to track @isidorn .

@rebornix rebornix added the verification-needed Verification of issue is requested label Mar 31, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
notebook polish Cleanup and polish issue ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants