Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons in the quick pick are not horizontally centered #93906

Closed
moshfeu opened this issue Mar 31, 2020 · 3 comments
Closed

Icons in the quick pick are not horizontally centered #93906

moshfeu opened this issue Mar 31, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons polish Cleanup and polish issue quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@moshfeu
Copy link
Contributor

moshfeu commented Mar 31, 2020

The "gear" and the "trash" icons are not centered in their outlines

For example:

Follow up issue of #89443 (comment)

Version: 1.44.0-insider
Commit: 13b38d2a494612ace32c4fb878824d6329d4c51e
Date: 2020-03-30T07:30:34.234Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.3.0

Steps to Reproduce:

  1. Hit ctrl + ~
  2. Create new integrated terminal
  3. Hit ctrl + ~ (repeat step 1)
  4. Hit tab 3 times (focus on the gear icon)

Does this issue occur when all extensions are disabled?: Yes

@moshfeu moshfeu changed the title Pick internal terminal icons are not centered inside the its outline Pick internal terminal icons are not centered inside their outline Mar 31, 2020
@miguelsolorio miguelsolorio assigned bpasero and unassigned Tyriar Mar 31, 2020
@miguelsolorio
Copy link
Contributor

This is actually a case with all icons in the quick pick:

image

FYI @bpasero looks like the width rule here is causing this:

.quick-input-list .quick-input-list-entry-action-bar .action-label.codicon {
margin: 0;
width: 19px;
height: 100%;
vertical-align: middle;
}

@miguelsolorio miguelsolorio changed the title Pick internal terminal icons are not centered inside their outline Icons in the quick pick are not horizontally centered Mar 31, 2020
@miguelsolorio miguelsolorio added bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons quick-pick Quick-pick widget issues labels Mar 31, 2020
@miguelsolorio miguelsolorio added this to the March 2020 milestone Mar 31, 2020
@miguelsolorio
Copy link
Contributor

This should be fixed:

image

And in the recent menu:
image

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

@misolori thanks!

jeyj0 pushed a commit to jeyj0/vscode that referenced this issue Mar 31, 2020
@miguelsolorio miguelsolorio added the polish Cleanup and polish issue label Mar 31, 2020
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug icons-product Issues for in-product icons polish Cleanup and polish issue quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants