Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all tasks does nothing when a webview is opened in the background #93950

Closed
Tyriar opened this issue Mar 31, 2020 · 2 comments
Closed

Show all tasks does nothing when a webview is opened in the background #93950

Tyriar opened this issue Mar 31, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2020

#93641

Version: 1.44.0-insider (user setup)
Commit: d7d1147
Date: 2020-03-31T08:23:56.446Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18362


Works fine when a file is opened, not an extension (webview) though.

4ca44d10-8157-4db0-8ea9-719c7aa69b57

Is this a wider problem with multi-step quick picks?

@IllusionMH
Copy link
Contributor

Looks similar to #75209

@chrmarti chrmarti added quick-pick Quick-pick widget issues bug Issue identified by VS Code Team member as probable bug labels Apr 1, 2020
@chrmarti chrmarti added this to the March 2020 milestone Apr 1, 2020
@chrmarti
Copy link
Contributor

chrmarti commented Apr 2, 2020

This is an interaction between QuickInput and the WebView. When the first picker closes, it passes focus back to the editor which passes it to the webview element. The second picker then opens and takes the focus only to loose it immediately after.

I don't see 'focusin' nor 'focusout' events for the webview element, so that element seems to somehow be special. @mjbvz Do you have an idea of what might be going on here?

@chrmarti chrmarti modified the milestones: March 2020, On Deck Apr 2, 2020
@mjbvz mjbvz self-assigned this Apr 15, 2020
@mjbvz mjbvz modified the milestones: On Deck, April 2020 Apr 15, 2020
@mjbvz mjbvz closed this as completed in 870700e Apr 15, 2020
@bpasero bpasero added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants