Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewsWelcome#view schema definition #94028

Closed
JacksonKearl opened this issue Mar 31, 2020 · 3 comments
Closed

viewsWelcome#view schema definition #94028

JacksonKearl opened this issue Mar 31, 2020 · 3 comments
Assignees
@isidorn @alexr00
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone
March 2020

Comments

@JacksonKearl
Copy link
Contributor

#91269

If I understand correctly, viewsWelcome is only enabled for "view": "scm" | "explorer" | "debug". It'd be nice to include these in the json schema definition so developers know what to put in that field.
@alexr00
Copy link
Member

alexr00 commented Apr 1, 2020

It is available for all custom contributed tree views now! I deleted that from the schema this month :).

@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020

@alexr00 but we should still offer scm explorer and debug and idealy have this open ended that when users put in anything else they do not get an error.
Not sure if possible to be done with a json schema
fyi @joaomoreno

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels Apr 1, 2020
@alexr00 alexr00 added this to the March 2020 milestone Apr 1, 2020
@alexr00 alexr00 closed this as completed in 51d4058 Apr 1, 2020
@alexr00
Copy link
Member

alexr00 commented Apr 1, 2020

Yes, it is possible with json schema.

alexr00 added a commit that referenced this issue Apr 3, 2020
@alexr00
oneOf -> anyOf in welcome view schema
d719bbd 
fixes #94028
@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@isidorn @JacksonKearl @alexr00