Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"statusBar/windowIndicator" and "menuBar/webNavigation" not included in intellisense #94054

Closed
RMacfarlane opened this issue Mar 31, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@RMacfarlane
Copy link
Contributor

Testing #93635

  1. In an extension's package.json, start writing under "menus" in the contribution section. The new menu contribution points are not suggested:
    Screen Shot 2020-03-31 at 1 30 36 PM
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

I think this is intentional since those menus are proposed API.

@jrieken jrieken assigned bpasero and aeschli and unassigned jrieken Apr 1, 2020
bpasero added a commit that referenced this issue Apr 1, 2020
@bpasero bpasero assigned joaomoreno and unassigned bpasero Apr 1, 2020
@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

I added the entry for the web menu.

There seems to be more missing, also in SCM. Adding @joaomoreno

Needs to be added to:

export const menusContribution: IJSONSchema = {

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

@aeschli is anyone using the "File" top level menu contribution point after all?

joaomoreno added a commit that referenced this issue Apr 1, 2020
related to #94054
@joaomoreno joaomoreno removed their assignment Apr 1, 2020
@aeschli
Copy link
Contributor

aeschli commented Apr 1, 2020

@bpasero We removed the remote usage, so it's not used (to my knowledge)

@bpasero
Copy link
Member

bpasero commented Apr 1, 2020

Ok then maybe we should remove it entirely.

@aeschli
Copy link
Contributor

aeschli commented May 7, 2020

Remove the menuBar/file entry.

@aeschli aeschli closed this as completed May 7, 2020
@aeschli aeschli added this to the May 2020 milestone May 7, 2020
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label May 7, 2020
@joaomoreno joaomoreno added the verified Verification succeeded label Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants