Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: Unable to load github notebook extension on linux #94218

Closed
deepak1556 opened this issue Apr 1, 2020 · 3 comments
Closed

Notebooks: Unable to load github notebook extension on linux #94218

deepak1556 opened this issue Apr 1, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone

Comments

@deepak1556
Copy link
Contributor

Testing #93742

  1. Tried both 0.0.4 and 0.0.3 version from the release page
  2. Follow error message is shown on console when the extension is loaded

Screen Shot 2020-04-01 at 2 40 53 PM

@rebornix
Copy link
Member

rebornix commented Apr 1, 2020

This is because the vsix @jrieken uploaded ships with OctokitProvider.js while on Linux, file paths are case sensitive. I updated the vsix on the release page but still leave this open, then @jrieken remembers to update the file name locally ;)

@jrieken
Copy link
Member

jrieken commented Apr 2, 2020

I blame it on the extract-to-file refactoring from TypeScript. It makes uppper-case filenames and when renaming them to lower-case the compiler doesn't re-emit/clear

@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 2, 2020
@jrieken jrieken added this to the March 2020 milestone Apr 2, 2020
jrieken added a commit to microsoft/vscode-github-issue-notebooks that referenced this issue Apr 2, 2020
@jrieken
Copy link
Member

jrieken commented Apr 2, 2020

This casing-fix is now in 0.0.5 - https://github.com/microsoft/vscode-github-issue-notebooks/releases

@jrieken jrieken closed this as completed Apr 2, 2020
@connor4312 connor4312 added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants