Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running theme extension, theme only works every other time #94273

Closed
weinand opened this issue Apr 2, 2020 · 2 comments
Closed

When running theme extension, theme only works every other time #94273

weinand opened this issue Apr 2, 2020 · 2 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Milestone
April 2020

Comments

@weinand
Copy link
Contributor

weinand commented Apr 2, 2020

refs #93804:

  • create new color theme with yeoman
  • open in VS Code
  • run theme with F5
  • stop extension
  • run theme with F5
  • stop extension
    etc.

Observe:
the theme is only activated every other time
@rafaelrenanpacheco
Copy link

Don't know if this could be related, but the changes I make on my theme only starts to be applied if I change the current "Extension Development Host" to another theme, then back again to my theme. Only after that I can start modifying the theme and get it applied real time.

@aeschli aeschli closed this as completed in a5760ef Apr 9, 2020
aeschli added a commit that referenced this issue Apr 9, 2020
@aeschli
themes: watching in dev only works when setting theme is set (for #94273
8b0ff03 
)
@aeschli
Copy link
Contributor

aeschli commented Apr 9, 2020

@rafaelrenanpacheco Not related, but I found the issue and pushed a fix

@aeschli aeschli added this to the April 2020 milestone Apr 9, 2020
@aeschli aeschli added bug Issue identified by VS Code Team member as probable bug themes Color theme issues labels Apr 9, 2020
@weinand weinand added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@weinand @aeschli @rafaelrenanpacheco