New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchEditor: Add command to focus queryEditorWidget #94439
Comments
@JacksonKearl Can I contribute to this issue? |
@kdnk I'm currently in the middle of a large refactoring of the search editor, which will almost certainly make merging any work you do difficult. However it should be completed in the coming days. I may end up fixing this as part of the refactoring, but if not I'll ping you when I'm done! |
Hey @kdnk, refactoring is in. If you want to take this onn you can start by looking at how we declare actions here: vscode/src/vs/workbench/contrib/searchEditor/browser/searchEditorActions.ts Lines 114 to 141 in 379e732
and how they get registered and assigned here: vscode/src/vs/workbench/contrib/searchEditor/browser/searchEditor.contribution.ts Lines 207 to 209 in 379e732
|
Thanks! I'll work on it! |
When I run the command Search Editor: Focus Search Editor Query Widget nothing happens. I assume I need to take some action first that causes the widget to show. If the command isn't always applicable, it should have a when clause so that it isn't run from the command palette with no effect. |
Thanks, fixed. |
Still happens. Steps
Also please rename the action to be called |
Thanks, updated. |
Thanks, works fine now. Adding verified label. |
I note that the Version: 1.45.0-insider (user setup) |
Thanks, fixed. |
I want a command to focus on the queryEditorWidget in SearchEditor.
I use the SeachEditor feature with VScodeVim so I frequently use the ESC key. But I put the ESC to switch to normal mode but the cursor focuses on the queryEditorWidget.
I want to set another shortcut to do this but I can't.
I read source code and identified the cause of the focus on queryEditorWidget by ESC.
If I could I want to add a configurable command like
search.action.focusQueryEditorWidget
to focus on the queryEditorWidget.The text was updated successfully, but these errors were encountered: