Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action "merge all windows" gone after update to 1.44 #94734

Closed
ryenus opened this issue Apr 9, 2020 · 7 comments
Closed

Action "merge all windows" gone after update to 1.44 #94734

ryenus opened this issue Apr 9, 2020 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-os-integration Native OS integration issues

Comments

@ryenus
Copy link
Contributor

ryenus commented Apr 9, 2020

  • VSCode Version: 1.44
  • OS Version: macOS 10.15.4

This happened after updating to 1.44.

Steps to Reproduce:

  1. set window.nativeTabs to true, and restart
  2. open command palette
  3. search for action "merge all windows"

Does this issue occur when all extensions are disabled?: Yes/No

@RMacfarlane
Copy link
Contributor

@ryenus I'm having trouble finding where this was registered in the command palette before, do you remember what version you updated from? I still see it in the "Window" menu:
Screen Shot 2020-04-09 at 9 46 22 AM

@ryenus
Copy link
Contributor Author

ryenus commented Apr 9, 2020

@RMacfarlane thanks for looking into this, I upgraded from 1.43.2.

@bsdahl
Copy link

bsdahl commented Apr 10, 2020

This is a breaker for me. I use the Native tabs command every day as a part of my workflow and VS Code feels broken without them.

All of the Native Tab commands are missing in the latest update.

  • "New Window Tab"
  • "Show Previous Window Tab"
  • "Show Next Tab"
  • "Move Tab to New Window"
  • "Merge All Windows"

@sbatten sbatten assigned bpasero and unassigned sbatten Apr 10, 2020
@sbatten
Copy link
Member

sbatten commented Apr 10, 2020

looks like you updated the way these are contributed recently @bpasero

@bpasero
Copy link
Member

bpasero commented Apr 11, 2020

I cannot reproduce this:

image

@sbatten what change are you referring to?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 11, 2020
@bsdahl
Copy link

bsdahl commented Apr 11, 2020

@bpasero the Native tabs commands are missing from the command palette.

However they are still available by clicking on the Window menu in the top nav bar, as you can see.

Previously, they were available in the command palette as well.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release and removed info-needed Issue requires more information from poster labels Apr 11, 2020
@bpasero bpasero added this to the April 2020 milestone Apr 11, 2020
@bpasero bpasero added the workbench-os-integration Native OS integration issues label Apr 11, 2020
@bpasero
Copy link
Member

bpasero commented Apr 11, 2020

Confirmed, easy fix.

bpasero added a commit that referenced this issue Apr 11, 2020
bpasero added a commit that referenced this issue Apr 14, 2020
@bpasero bpasero closed this as completed Apr 14, 2020
@isidorn isidorn added the verified Verification succeeded label Apr 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-os-integration Native OS integration issues
Projects
None yet
Development

No branches or pull requests

6 participants