Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notification when extensionHostProcess.js is missing on disk #95237

Closed
alexdima opened this issue Apr 14, 2020 · 0 comments
Closed

Show notification when extensionHostProcess.js is missing on disk #95237

alexdima opened this issue Apr 14, 2020 · 0 comments
Assignees
@alexdima
Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verification-needed Verification of issue is requested verified Verification succeeded
Milestone
March 2020 Recove...

Comments

@alexdima
Copy link
Member

alexdima commented Apr 14, 2020 •
edited
Loading

This is a low risk reaction to #94858

We already have the infrastructure to show a message if we detect certain files in the VS Code installation have been altered. The idea is to add a check where we also validate extensionHostProcess.js and where we also detect the case where the file is missing (quarantined).

image

The link redirects to https://code.visualstudio.com/docs/supporting/faq#_installation-appears-to-be-corrupt-unsupported and we should also update the website to mention that certain antivirus can mistakenly quarantine VS Code files.
@alexdima alexdima self-assigned this Apr 14, 2020
@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Apr 14, 2020
@alexdima alexdima added this to the March 2020 Recovery milestone Apr 14, 2020
@alexdima alexdima added the important Issue identified as high-priority label Apr 14, 2020
@alexdima alexdima mentioned this issue Apr 14, 2020
Merged
@alexdima alexdima added the verification-needed Verification of issue is requested label Apr 14, 2020
@alexr00 alexr00 added the verified Verification succeeded label Apr 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
March 2020 Recovery 2
Development

No branches or pull requests
2 participants
@alexdima @alexr00