Web: hamburger menu does not have tabIndex

[bpasero]

You cannot "tab" through the web interface to eventually reach the hamburger menu because it does not have any tabIndex it seems.

//cc @isidorn

Related: #82759

[isidorn]

We should fix this asap. Assignin to May and to myself so we look into this.

[isidorn]

Ok looked a bit into this and there are a couple of more issues:

1. Hambuger menu does not belong to the composite bar and thus up / down navigation does not travel to it
2. If I make the Hamburger menu focusable via tabIndex as soon as it is focused the focus gets stuck there due to this code
3. Hamburger menu expands menu when down is pressed, it should also expand when right and space are pressed

@sbatten is it possible to maybe put this on the plan so we fix the hamburger menu with regards to these issues?

[isidorn]

SteVen informed me this will happen.
Thus unassigning myself. SteVen let me know if I can help and feel free to assign this issue to me again.

[sbatten]

@isidorn I made it accessible via tab and allow space to trigger. Because it isn't really part of the viewlet icons I did not allow right. I found that it would be confusing given pressing right on activity bar icon focuses the next icon.

[isidorn]

Thanks @sbatten I just tried it out and you can focus into it via tab. However my conern from above is still not tackled

• Hambuger menu does not belong to the composite bar and thus up / down navigation does not travel to it

Up / down navigation should navigate to it nicely, especialy since F6 focuses the activity bar and users use up / down to navigate over actions there.
Due to this reopening this issue.

[bpasero]

Is that a requirement for all things in the activity bar? Because we have more:

• Home Indicator
• Menu
• Views
• Accounts
• Gear

[isidorn]

Well idealy up / down would navigate through all the activity bar items. So yeah the Gear would also be a part of the navgiation.

[sbatten]

Is that right? The viewlets cycle through with arrows. More often than not, I would expect users to be navigating through those. You can always get to the menu or the next icon with tab.

[isidorn]

They visualy and html wise belogn to the same container. Thus arrow navigation should navigate through them - same as status bar does not require tab to jump from left to right aligned items.
Pressing tab to navigate from the top of the activity bar to the bottom does not make a lot of sense imho, tab should simply move focus out of the activity bar.

If we are undecided I can also ask for some feedback in our accessibility channel.
let me know what you think. thanks!

[sbatten]

I can see the value there, but analogously, should panel also have the right arrow move from panel titles to panel actions? Currently our action bar areas are treated as units that you must tab out.

[isidorn]

@sbatten yes I think that would be cool also in the panel.
The fact that we use differetn actionBars I feel is an implementation detail.

[sbatten]

If that's the case, I think this is a larger change than I anticipated and I may not be able to fit it in this milestone.

[isidorn]

Makes sense, feel free to move to June then. Thanks

[sbatten]

@isidorn I was unable to find a general solution for action bars, so instead, I looked for places where this made sense.

1. Activity Bar
2. Panel Header Area
3. Editor tab bar + actions

I tackled 1 with this issue. I will wait for your return to create separate issues for the other 2 if you are on board with them as well.