Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: unable to open / focus compact menu on macOS #82759

Closed
bpasero opened this issue Oct 17, 2019 · 12 comments
Closed

Web: unable to open / focus compact menu on macOS #82759

bpasero opened this issue Oct 17, 2019 · 12 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X menus Menu items and widget issues verified Verification succeeded web Issues related to running VSCode in the web
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 17, 2019

There seems to be no command that has a keybinding associated on macOS at least to trigger the compact menu. We should have a default keybinding that works on macOS (same as Linux and Windows too) to focus and show the main menu.

@bpasero bpasero added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues menus Menu items and widget issues web Issues related to running VSCode in the web labels Oct 17, 2019
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X labels Oct 17, 2019
@sbatten sbatten added this to the On Deck milestone Oct 17, 2019
@isidorn
Copy link
Contributor

isidorn commented Jun 9, 2020

Agree, this would be good to have.
@sbatten if you do not have time to look into this maybe you can provide a code pointer so we open this up for contributions?

@sbatten
Copy link
Member

sbatten commented Jun 9, 2020

Right now there is no such command to trigger for this but it would not be hard to add. My main question to get this to work would be, what should the keybinding be for web? alt works in windows/linux but macOS uses ^F2 as a standard for focusing the menu bar and we cannot override it even in full screen.

update: we can override it, so should we? the answer is likely yes

@isidorn
Copy link
Contributor

isidorn commented Jun 10, 2020

@sbatten thanks for looking into this!
It might be unexpected and weird for some users that we steal mac keybinding for focusing the top mac menu.
So currently I do not have a good suggestion. I just checked with our accessibility community to see if they have ideas since they know all the keybindings used for everything.

@isidorn
Copy link
Contributor

isidorn commented Jun 10, 2020

How about F10? Is that taken?

@sbatten
Copy link
Member

sbatten commented Jun 10, 2020

I think only when debugging, and we can bind to it safely, doesn't seem to do anything in the browser

@isidorn
Copy link
Contributor

isidorn commented Jun 10, 2020

Then I say we go with F10 as suggested by the Win98 Guide!

Screenshot 2020-06-10 at 20 39 27

@sbatten sbatten modified the milestones: On Deck, June 2020 Jun 10, 2020
@sbatten
Copy link
Member

sbatten commented Jun 11, 2020

@isidorn, found out today that there is a keybinding specific to node launch configs that start debugging on f10. Should we just let this conflict and have user choose or find a new bind?

@isidorn
Copy link
Contributor

isidorn commented Jun 12, 2020

@sbatten oh yeah F10 is start and stop on entry. Geeez...
I would just go with it and make sure the menu one wins. Since node-js only takes that when there is a launch configuration set.
I would maybe change the node-js one to also trigger one alt+F10
@connor4312 what do you think?

@connor4312
Copy link
Member

I'm fine removing that as a default keybining -- js debug doesn't support it. Since no one mentioned it yet it's probably fine to have it be unbound by default and available if anyone wants it.

@isidorn
Copy link
Contributor

isidorn commented Jun 12, 2020

Yeah. let's go loco and unbound by default.

@bpasero
Copy link
Member Author

bpasero commented Jun 30, 2020

I am not seeing this command (using yarn web):

image

@bpasero bpasero reopened this Jun 30, 2020
@bpasero bpasero added the verification-found Issue verification failed label Jun 30, 2020
sbatten added a commit that referenced this issue Jun 30, 2020
@sbatten
Copy link
Member

sbatten commented Jun 30, 2020

The keybinding was present, but it wasn't shown in the command palette. It will now show in the command palette as well.

@sbatten sbatten closed this as completed Jun 30, 2020
@sbatten sbatten removed the verification-found Issue verification failed label Jun 30, 2020
@bpasero bpasero added the verified Verification succeeded label Jul 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X menus Menu items and widget issues verified Verification succeeded web Issues related to running VSCode in the web
Projects
None yet
Development

No branches or pull requests

6 participants
@bpasero @isidorn @connor4312 @sbatten and others