Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest Widget CSS broken #95466

Closed
rebornix opened this issue Apr 16, 2020 · 2 comments
Closed

Suggest Widget CSS broken #95466

rebornix opened this issue Apr 16, 2020 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
April 2020

Comments

@rebornix
Copy link
Member

  • VSCode Version: Insiders/Web
  • OS Version: macOS
  • Open a github notebook document
  • Trigger suggest

image
rebornix referenced this issue Apr 16, 2020
@roblourens
Tweak notebook cell layout
d899dc7
@rebornix
Copy link
Member Author

Seems it's caused by d899dc7 , when we update css for monaco list view, we need to make sure that > is used: . monaco-list-rows > .monaco-list-row

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 16, 2020
@rebornix rebornix added this to the April 2020 milestone Apr 16, 2020
rebornix added a commit that referenced this issue Apr 16, 2020
@rebornix
Rollback Re #95466
0dd9d94
@rebornix
Copy link
Member Author

I pushed a change which temporarily fixes the problem. @roblourens please take a look if it breaks anything.

@rebornix rebornix removed their assignment Apr 16, 2020
rebornix added a commit that referenced this issue Apr 16, 2020
@rebornix
Re #95466. Fix cell margin.
483e822
@rebornix rebornix added the verified Verification succeeded label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
2 participants
@roblourens @rebornix