Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and re-enable remote terminal integrated tests #96057

Closed
Tyriar opened this issue Apr 24, 2020 · 7 comments · Fixed by #118252
Closed

Fix and re-enable remote terminal integrated tests #96057

Tyriar opened this issue Apr 24, 2020 · 7 comments · Fixed by #118252
Assignees
@Tyriar
Labels
integration-test-failure terminal Integrated terminal issues
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2020

They're probably flaky because there is still a case where the terminal won't launch microsoft/vscode-remote-release#2313
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues broken-build integration-test-failure labels Apr 24, 2020
@Tyriar Tyriar added this to the May 2020 milestone Apr 24, 2020
@Tyriar Tyriar self-assigned this Apr 24, 2020
Tyriar added a commit that referenced this issue Apr 24, 2020
@Tyriar
Disable terminal tests in remote
ae1670d 
Too flaky they're not useful.

See #96057
This was referenced Apr 27, 2020
Closed
Closed
@Tyriar Tyriar modified the milestones: May 2020, Backlog May 11, 2020
@joaomoreno joaomoreno removed broken-build debt Code quality issues labels Jun 21, 2020
@joaomoreno
Copy link
Member

@Tyriar Is this still an issue?

@vhood
Copy link

vhood commented Jul 21, 2020

@joaomoreno "the terminal won't launch" still is a very common problem.

@abhijeetmanhas
Copy link

abhijeetmanhas commented Jul 27, 2020 •
edited

I'm also facing similar of above ssues, whenever I use remote ssh.
Screenshot from 2020-07-27 12-46-09
No options are shown even

@davyarris
Copy link

I am also experiencing this issue. On WSL 1

@sameronline
Copy link

I'm constantly getting this issue and it's very frustrating....

@Dreamupers
Copy link

image

@Tyriar
Copy link
Member Author

Tyriar commented Sep 21, 2020

This issue is about tests, microsoft/vscode-remote-release#2313 is tracking the bug.

@microsoft microsoft locked as off-topic and limited conversation to collaborators Sep 21, 2020
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 22, 2020
@joaomoreno joaomoreno modified the milestones: Backlog, January 2021 Jan 7, 2021
@Tyriar Tyriar modified the milestones: January 2021, February 2021 Jan 25, 2021
@Tyriar Tyriar modified the milestones: February 2021, March 2021 Feb 22, 2021
Tyriar added a commit that referenced this issue Mar 9, 2021
@Tyriar
Remove remote test failure comment
d1dbb93 
FIxes #96057
@isidorn isidorn removed the bug Issue identified by VS Code Team member as probable bug label Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
integration-test-failure terminal Integrated terminal issues
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Consolidate local and remote terminal implementations microsoft/vscode
9 participants
@joaomoreno @sameronline @bpasero @isidorn @Tyriar @abhijeetmanhas @Dreamupers @vhood @davyarris