Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.gitignore_global should use the Ignore language mode #96079

Closed
johnbillion opened this issue Apr 24, 2020 · 1 comment · Fixed by #96080
Closed

.gitignore_global should use the Ignore language mode #96079

johnbillion opened this issue Apr 24, 2020 · 1 comment · Fixed by #96080
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2020

Comments

@johnbillion
Copy link
Contributor

When opening a .gitignore_global file, it doesn't use the Ignore language mode for syntax highlighting, commenting, etc. Opening a .gitignore file does.
@johnbillion johnbillion mentioned this issue Apr 24, 2020
Merged
@joaomoreno
Copy link
Member

.gitignore_global isn't a standard file name, it's just a suggestion given by GitHub. A user can always call it simply .gitignore. But sure... we'll take it...

@joaomoreno joaomoreno added feature-request Request for new features or functionality git GIT issues labels Apr 27, 2020
@joaomoreno joaomoreno added this to the April 2020 milestone Apr 27, 2020
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Apr 27, 2020
joaomoreno pushed a commit that referenced this issue Apr 27, 2020
@johnbillion
Treat .gitignore_global as an Ignore file by default. Fixes #96079.
4281e93
leilapearson pushed a commit to relmify/vscode that referenced this issue Apr 27, 2020
@johnbillion @leilapearson
Treat .gitignore_global as an Ignore file by default. Fixes microso…
3662f2b 
…ft#96079.
@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

Successfully merging a pull request may close this issue.

Treat .gitignore_global as an Ignore file by default.
3 participants
@joaomoreno @johnbillion @JacksonKearl