Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open with for custom editors doesn't always show active #96591

Closed
alexr00 opened this issue Apr 29, 2020 · 1 comment
Closed

Open with for custom editors doesn't always show active #96591

alexr00 opened this issue Apr 29, 2020 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2020

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 29, 2020

Testing #94347

It only shows which one is active if it's the built in editor:
image
image
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Apr 29, 2020
@mjbvz mjbvz added this to the April 2020 milestone Apr 29, 2020
@mjbvz mjbvz closed this as completed in 7f6f68a Apr 29, 2020
mjbvz added a commit that referenced this issue Apr 30, 2020
@mjbvz
Make getEditorOverrides take a uri instead of a editor input
0593e5b 
Better fix for #96591 to also work correctly with notebooks

In the explorer->open with command, we need to call `getEditorOverrides` but do not have a real editor input. Rather than creating a fake editor input, we should just take uri for `getEditorOverrides`
@mjbvz
Copy link
Contributor

mjbvz commented Apr 30, 2020

@rebornix 0593e5b Should fix this for notebooks too. As part of the fix, changed getEditorOverrides to take a resource instead of an editor input

@rebornix rebornix added the verified Verification succeeded label May 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@rebornix @mjbvz @alexr00