Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task instance limit is no longer respected #96999

Closed
alexr00 opened this issue May 5, 2020 · 2 comments
Closed

Task instance limit is no longer respected #96999

alexr00 opened this issue May 5, 2020 · 2 comments
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken tasks Task system issues verified Verification succeeded
Milestone
April 2020

Comments

@alexr00
Copy link
Member

alexr00 commented May 5, 2020 •
edited

Example task for Windows:

		{
			"label": "timeout",
			"command": "timeout 30",
			"type": "shell",
			"problemMatcher": [],
			"runOptions": {
				"instanceLimit": 2
			}
		},
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken labels May 5, 2020
@alexr00 alexr00 added this to the April 2020 milestone May 5, 2020
@alexr00 alexr00 self-assigned this May 5, 2020
@gjsjohnmurray
Copy link
Contributor

Maybe #96959 is related?

@alexr00
Copy link
Member Author

alexr00 commented May 5, 2020

Yes, it is absolutely related.

@alexr00 alexr00 mentioned this issue May 5, 2020
Closed
alexr00 added a commit that referenced this issue May 5, 2020
@alexr00
Fix task instance limit
7738654 
Part of #96999
alexr00 added a commit that referenced this issue May 5, 2020
@alexr00
Fix task instance limit
8504efe 
Part of #96999
@alexr00 alexr00 mentioned this issue May 5, 2020
Merged
alexr00 added a commit that referenced this issue May 5, 2020
@alexr00
Fix task instance limit (#97011)
96b89dd 
Fixes #96999
@alexr00 alexr00 closed this as completed May 5, 2020
@sandy081 sandy081 added the verified Verification succeeded label May 6, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release regression Something that used to work is now broken tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
April 2020
Development

No branches or pull requests
3 participants
@gjsjohnmurray @sandy081 @alexr00