Debug: Toggle Auto Attach should change user settings by default, not workspace settings #97087
Assignees
Labels
debug
Debug viewlet, configurations, breakpoints, adapter issues
insiders-released
Patch has been released in VS Code Insiders
polish
Cleanup and polish issue
Milestone
Comments
weinand
added
the
debug
connor4312
added a commit
that referenced
this issue
Sep 11, 2020
This PR removes the hook in node-debug's auto attach, and uses only js-debug auto attach. As referenced in the linked issues, this involves removing `debug.javascript.usePreviewAutoAttach` and collapsing `debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The latter option gains a new state: `disabled`. Since there's no runtime cost to having auto attach around, there is now no distinct off versus disabled state. The status bar item and the `Debug: Toggle Auto Attach` command now open a quickpick, which looks like this:  The current setting value is selected in the quickpick. If there is a workspace setting for auto attach, the quickpick toggle the setting there by default. Otherwise (as in the image) it will target the user settings. The targeting is more explicit and defaults to the user instead of the workspace, which should help reduce confusion (#97087). Selecting the "scope change" item will reopen the quickpick in that location. Aside from the extra options for the `disabled` state in js-debug's contributions, there's no changes required to it or its interaction with debug-auto-launch. Side note: I really wanted a separator between the states and the scope change item, but this is not possible from an extension #74967. Fixes #105883 Fixes microsoft/vscode-js-debug#732 (the rest of it) Fixes #105963 Fixes #97087
41 tasks
|
Referenced in the PR, auto attach now toggles globally by default, except if there's already a workspace setting present that would override it. In both cases, there's a button on the quickpick that you can use to swap into the other scope. |
sandy081
pushed a commit
that referenced
this issue
Sep 16, 2020
This PR removes the hook in node-debug's auto attach, and uses only js-debug auto attach. As referenced in the linked issues, this involves removing `debug.javascript.usePreviewAutoAttach` and collapsing `debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The latter option gains a new state: `disabled`. Since there's no runtime cost to having auto attach around, there is now no distinct off versus disabled state. The status bar item and the `Debug: Toggle Auto Attach` command now open a quickpick, which looks like this:  The current setting value is selected in the quickpick. If there is a workspace setting for auto attach, the quickpick toggle the setting there by default. Otherwise (as in the image) it will target the user settings. The targeting is more explicit and defaults to the user instead of the workspace, which should help reduce confusion (#97087). Selecting the "scope change" item will reopen the quickpick in that location. Aside from the extra options for the `disabled` state in js-debug's contributions, there's no changes required to it or its interaction with debug-auto-launch. Side note: I really wanted a separator between the states and the scope change item, but this is not possible from an extension #74967. Fixes #105883 Fixes microsoft/vscode-js-debug#732 (the rest of it) Fixes #105963 Fixes #97087
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
and others
cc @connor4312
I was confused why the auto attach status bar entry kept disappearing and I kept getting prompts to relaunch my terminals. This was happening because the toggle auto attach command saves a workspace setting, which I never want to commit so it always ends up getting cleared. Auto attach is something I want to toggle on briefly and then toggle off again and I would prefer use the command/keybinding rather than the mouse.
Related: #53640
The text was updated successfully, but these errors were encountered: