Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings for SCM input font family #97139

Merged
merged 5 commits into from
May 11, 2020
Merged

Add settings for SCM input font family #97139

merged 5 commits into from
May 11, 2020

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented May 7, 2020

This PR fixes #55169

@lszomoru lszomoru requested a review from joaomoreno May 7, 2020 10:19
@lszomoru lszomoru self-assigned this May 7, 2020
joaomoreno
joaomoreno requested changes May 7, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Only some small changes are needed.

extensions/git/package.json Outdated Show resolved Hide resolved
src/vs/workbench/contrib/scm/browser/repositoryPane.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/scm/browser/repositoryPane.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/scm/browser/repositoryPane.ts Outdated Show resolved Hide resolved
@lszomoru lszomoru requested a review from joaomoreno May 7, 2020 13:43
@lszomoru lszomoru changed the title Git: Add settings for commit message font family Git: Add settings for SCM input font family May 7, 2020
@lszomoru lszomoru changed the title Git: Add settings for SCM input font family Add settings for SCM input font family May 7, 2020
joaomoreno
joaomoreno approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

I wonder if we should have some value templates, eg:

  • default would mean the current value
  • editor would mean inherit the same font as the editor
  • anything else would be taken literally as the actual font name

@lszomoru lszomoru requested a review from joaomoreno May 11, 2020 09:11
@lszomoru lszomoru force-pushed the lszomoru/git-commit-message-font-family branch from 6a870ee to 40f8ac3 Compare May 11, 2020 09:45
@lszomoru lszomoru merged commit 6c39dda into master May 11, 2020
@lszomoru lszomoru deleted the lszomoru/git-commit-message-font-family branch May 11, 2020 10:20
@lszomoru lszomoru added this to the May 2020 milestone May 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@lszomoru lszomoru

Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.

SCM: Support monospace font in commit input field
2 participants
@lszomoru @joaomoreno