Debt: use ipc to communicate with the auth dialog #97301
Labels
debt
Code quality issues
insiders-released
Patch has been released in VS Code Insiders
sandbox
Running VSCode in a node-free environment
Milestone
Follow-up to #97199 , since
executeJavaScript
calls are hard to debug and they are just inline script evaluation that can easily break CSP.BrowserWindowConstructorOptions
for the auth windowfrom
to
Setup ipc channel in the preload script
Replace
executeJavaScript
call invs/code/electron-main/auth.ts
withwin.webContents.send
This will align well with #92164
/cc @bpasero once you setup a structure for how preload communication should look, we can adopt it here.
The text was updated successfully, but these errors were encountered: