Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sandbox for issue reporter and process explorer #101834

Closed
bpasero opened this issue Jul 7, 2020 · 2 comments · Fixed by #111304
Closed

Enable sandbox for issue reporter and process explorer #101834

bpasero opened this issue Jul 7, 2020 · 2 comments · Fixed by #111304
Assignees
@bpasero @deepak1556
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment
Milestone
November 2020

Comments

@bpasero
Copy link
Member

bpasero commented Jul 7, 2020 •
edited

This depends on the following individual issues for removing Electron/node.js dependencies:

After the issues are closed, sandbox and contextIsolation should be enabled. This will likely require a separate version of globals.ts that works via the related APIs in Electron to expose APIs to the renderer (contextbridge).
@bpasero bpasero added the sandbox Running VSCode in a node-free environment label Jul 7, 2020
@egamma egamma mentioned this issue Jul 7, 2020
Closed
2 tasks
@kieferrm kieferrm mentioned this issue Jul 10, 2020
Closed
49 tasks
@bpasero
Copy link
Member Author

bpasero commented Jul 20, 2020

This is blocked by missing NLS support in sandboxed environments. Related code pointer:

vscode/src/bootstrap-window.js

Line 73 in 993df78

const nlsConfig = sandbox ? { availableLanguages: {} } : globalThis.MonacoBootstrap.setupNLS();

@bpasero bpasero changed the title Enable sandbox for issue reporter, process explorer and auth dialog Enable sandbox for issue reporter and process explorer Oct 31, 2020
@deepak1556 deepak1556 added the debt Code quality issues label Nov 5, 2020
@bpasero
Copy link
Member Author

bpasero commented Nov 25, 2020

2433e29 enables NLS support when sandbox is on.

bpasero added a commit that referenced this issue Nov 25, 2020
@bpasero
Enable sandbox for issue reporter and process explorer (fix #101834)
53df32f
@bpasero bpasero mentioned this issue Nov 25, 2020
Merged
bpasero added a commit that referenced this issue Nov 25, 2020
@bpasero
Enable sandbox, contextIsolation and vscode-file for process explorer…
37e9cce 
… and issue reporter (#111304)

* Enable sandbox for issue reporter and process explorer (fix #101834)

* sandbox - enable vscode-file protocol for sandboxed renderers

* issues - stop setting nodeCachedDataDir

* address feedback and also use vscode-file for shared process if sandbox is on
@bpasero bpasero added this to the November 2020 milestone Nov 25, 2020
@bpasero bpasero self-assigned this Nov 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@deepak1556 deepak1556

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders sandbox Running VSCode in a node-free environment
Projects
None yet
Milestone
November 2020
3 participants
@bpasero @deepak1556 and others