Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug hover is too narrow and horizontal scrolling useless #97471

Closed
weinand opened this issue May 11, 2020 · 7 comments
Closed

Debug hover is too narrow and horizontal scrolling useless #97471

weinand opened this issue May 11, 2020 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented May 11, 2020

Insiders:

The debug hover is too narrow and horizontal scrolling is useless because it allows only to see a few more characters.

2020-05-11_09-30-24 (1)

In order to be useful a debug hover must allow horizontal scrolling to the very end of every string.
And it would help if the default size of a debug hover is at least 50% wider.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels May 11, 2020
@isidorn
Copy link
Contributor

isidorn commented May 11, 2020

Agree, we could improve this.
However we are not controlling the width, that is done by the Tree.
@joaomoreno is there some way for me as a client to increase the width of each element? I can do it via css and adding a margin, but to check if there is something leaner?

@weinand
Copy link
Contributor Author

weinand commented May 11, 2020

I would even tolerate if the width of the tree is set to some hardcoded value (e.g. 1500).

@joaomoreno
Copy link
Member

However we are not controlling the width, that is done by the Tree.

What do you mean? You control the width of the container, the tree just fits to 100% of its width.

@isidorn
Copy link
Contributor

isidorn commented May 11, 2020

@joaomoreno yes you are right, but we do not control the width between the end of the element and the start of the vertical scroll bar. Thus what we need is a small width margin at the end each element so it does not overlap the vertical scroll bar. I can do that via css.

@weinand
Copy link
Contributor Author

weinand commented May 11, 2020

Please note: the overlap between the content and the vertical scrollbar is not the issue: I want to be able to scroll horizontally to the end of the string!

@isidorn
Copy link
Contributor

isidorn commented May 11, 2020

@weinand ok, sorry I misunderstood you.
@joaomoreno sorry for the ping this issue is on my side.

@isidorn isidorn added this to the May 2020 milestone May 11, 2020
@weinand
Copy link
Contributor Author

weinand commented Jun 4, 2020

@isidorn works great now!

@weinand weinand added verified Verification succeeded on-release-notes Issue/pull request mentioned in release notes labels Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues on-release-notes Issue/pull request mentioned in release notes verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants